On Thu, Apr 21, 2022 at 09:26:36PM +0800, Teng Long wrote: > In "open_midx_bitmap()", we do a loop with the MIDX(es) in repo, when > the first one has been found, then will break out by a "return" > directly. > > But actually, it's better to don't stop the loop until we have visited s/don't stop/continue > both the MIDX in our repository, as well as any alternates (along with > _their_ alternates, recursively). > > The discussion link of community: > > https://public-inbox.org/git/YjzCTLLDCby+kJrZ@nand.local/ In the future, it is often worth summarizing the discussion, optionally linking off to the list archive. In this case, I wouldn't mind a little more detail beyond "it's better to [continue] the loop until ...". In particular, you say it's better without saying why that is the case. The link to <YjzCTLLDCby+kJrZ@nand.local> explains, but this commit message as-is leaves out some details that are important IMHO. > --- > pack-bitmap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) The actual changes look good to me. Thanks, Taylor
