On Mon, May 09, 2022 at 02:45:21PM -0700, Junio C Hamano wrote: > SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > > > repositoy could trivially safe-list itself. However, it's unclear (to > > me) why 'git -c safe.directory=...' is ignored: 8959555cee > > (setup_git_directory(): add an owner check for the top-level > > directory, 2022-03-02) only states that it's ignored, but doesn't > > justify why. Now, let's suppose that there was a compelling reason to > > Correct. I do not think it is a restriction with any sensible > justification, just that it happened to be implemented that way. > > IOW, I am saying that GIT_SAFE_DIRECTORIES may be a lot nicer user > interface than fixing the "we ignore 'git -c safe.directory'?" bug. In light of this, I'm not sure we want to test said buggy behavior. IOW, do we want 2/3 and 3/3 of this patch series at all? Or perhaps add those test as 'test_expect_failure' instead?
