Currently, test-dir-iterator does not check for errno error codes set by
an unsuccessful dir_iterator_advance() call. We do check for them,
however, in dir_iterator_begin(). Make it such that test-dir-iterator
does checks for them in dir_iterator_advance() as well.
This improves test coverage because it provides more detailed outputs
regarding errno error codes set by dir_iterator_advance(), which in turn
allows for the addition of more thorough tests over dir-iterator.
Signed-off-by: Plato Kiorpelidis <kioplato@xxxxxxxxx>
---
t/helper/test-dir-iterator.c | 2 +-
t/t0066-dir-iterator.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/helper/test-dir-iterator.c b/t/helper/test-dir-iterator.c
index cdb9269ad5..55d8a58836 100644
--- a/t/helper/test-dir-iterator.c
+++ b/t/helper/test-dir-iterator.c
@@ -59,7 +59,7 @@ int cmd__dir_iterator(int argc, const char **argv)
}
if (iter_status != ITER_DONE) {
- printf("dir_iterator_advance failure\n");
+ printf("dir_iterator_advance failure: %s\n", error_name(errno));
return EXIT_FAILURE;
}
diff --git a/t/t0066-dir-iterator.sh b/t/t0066-dir-iterator.sh
index b21c58ade3..61b02423d5 100755
--- a/t/t0066-dir-iterator.sh
+++ b/t/t0066-dir-iterator.sh
@@ -90,7 +90,7 @@ test_expect_success POSIXPERM,SANITY 'advance should not fail on errors by defau
test_expect_success POSIXPERM,SANITY 'advance should fail on errors, w/ pedantic flag' '
cat >expected-out <<-EOF &&
[d] (a) [a] ./dir3/a
- dir_iterator_advance failure
+ dir_iterator_advance failure: EACCES
EOF
chmod 0 dir3/a &&
--
2.36.1
