On Mon, May 09, 2022 at 09:08:46AM -0700, Junio C Hamano wrote: > > I don't think so. bisect_log_printf() has only one caller, which is > > bisect_print_status(). Couldn't the latter manage its own strbuf without > > the need to introduce a new varargs function? > > I actually was hoping that other existing informational messages > prefixed with "Bisecting:" (i.e. those that tells you how many steps > are remaining) can go as similar comments to the log file; they are > currently written with plain-vanilla printf(3), and could use this > one instead. I see. In that case I agree that we this function should take varargs, and it should pass that va_list to strbuf_vaddf(). But this patch shouldn't reimplement the wheel here with a bare vsnprintf() call that could be replaced with a strbuf. Thanks, Taylor
