On Mon, May 09, 2022 at 11:32:48AM +0000, Abhradeep Chakraborty via GitGitGadget wrote:
> From: Abhradeep Chakraborty <chakrabortyabhradeep79@xxxxxxxxx>
>
> `git remote -v` (`--verbose`) lists down the names of remotes along with
> their URLs. It would be beneficial for users to also specify the filter
> types for promisor remotes. Something like this -
This version looks like it has addressed many (all?) of the comments
previously discussed during review. On a quick scan, the code and tests
look good to my eyes, too.
But there was a good question raised by Phillip in
https://lore.kernel.org/git/ab047b4b-6037-af78-1af6-ad35ac6d7c90@iee.email/
that I didn't see addressed in your response, which was "why not put
this behind a new `--show-partial-filter` option"?
I share (what I think is) Junio's feeling that having information that
is readily available from e.g., running "git config --get
remote.<name>.partialObjectFilter" seems redundant. I could understand
forcing a user to know the config key's name feels like a hurdle. But
cluttering the output of `git remote -v` seems like the wrong solution
to that hurdle.
But I can see where it _would_ be useful. So it would be nice to be able
to turn the extra output on in those cases, but _only_ those cases, and
a flag would be a nice way to go about doing that.
Thanks,
Taylor
