Philippe Blain <levraiphilippeblain@xxxxxxxxx> wrote: > I think the tests woud fit better in t5505-remote.sh, since the patch really > adds a feature to the 'git remote' command. I think you're right. Thanks! > I found it sligtly awkward to use the future tense here. Maybe just: > > For promisor remotes, also show which filter > (`blob:none` etc.) that promisor remote use, wrapped in square brackets. > > And technically, it's not really the remote that "uses" the filter, > but more the local Git client. So maybe something like this would > be more accurate and simpler: > > For promisor remotes, also show which filter (`blob:none` etc.) > are configured, wrapped in square brackets. > > And even then "wrapped in square brackets" *could* be dropped, I > think. Got it. Thanks for the suggestions about both the PR and the patch. Will update it. Thanks :)
