Junio C Hamano <gitster@xxxxxxxxx> wrote: > Broken indentation. You can save embarrassment by double checking > what you committed by sending e-mail to yourself (or checking output > from "git show") before sending it to the list. Thanks for the suggestions. Will keep it in mind next time. > I doubt that these "grep" do what you think it is doing. It would > say "I am happy" on any line that has one of these characters listed > inside the []. > > Do not clean up with an extra "&& clean up" step at the end of > &&-cascade. Instead use test_when_finished to make sure that after > any failure in the cascade the clean-up step would still trigger. > > test_expect_success 'title' ' > test_when_finished "rm -fr pc2" && > git clone ... && > ... > grep "srv.bare (fetch) \[object:type=commit\]" out > ' > > or something. > > Having tests that show how this new feature works is of course > necessary, but we must have negative tests that ensure that it does > *not* trigger when it should not. E.g. the new [filter-spec] should > not be given for a remote if the user didn't ask for "-v", or the > remote is not a promisor. Got it. Will send the necessary changes by the day after tommorow. Thanks :)
