On Wed, Apr 27, 2022 at 5:30 AM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > You are ignoring any errors when parsing the environment variable - that > is not a good idea in a security check. which errors are you concerned about?, if anything in this code worries me from a security point of view is the fact that we are relying in getenv not being racy (as mentioned in the original RFC), but there are no errors set there AFAIK. not ignoring errno in strtol is an option, but as mentioned before I decided instead to reject bogus values and therefore not the clobber a previous errno, since I was using strtol as a wider version of atoi. Carlo
