Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Apr 19, 2022 at 8:33 AM Jack McGuinness
<jmcguinness2@xxxxxxxxxxxx> wrote:
>
> Hi, thank you for the advice. I wanted it to be that way myself, however I was using gitgitgadget to email it, and my PR was composed of three different commits, which caused it to automatically be formatted that way. I tried finding a way to remove it, but I had no luck, If you know how I would love to know!

I don't use gitgitgadget, so I cannot help you much on this. The
approach I would take if I had to use it would be to find patches on
the mailing list that were sent using gitgitgadget by experienced
developers using it, then find and see how the corresponding PRs look
like on GitHub, and try to imitate those PRs.

Anyway, it would be nice if you could try again taking into account
Junio's suggestions in:

https://lore.kernel.org/git/xmqqmtggs2nv.fsf@gitster.g/

I also have some suggestions below.

> To: Jack McGuinness via GitGitGadget; git@xxxxxxxxxxxxxxx
> Cc: Jack McGuinness
> Subject: Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script

This is your second attempt so it would be nice if it had a "v2"
marker in it like "[PATCH v2 0/3] [GSoC]" instead of "[PATCH 0/3]
[GSoC][Patch]". (Your next attempt should use "v3".)

> On 4/19/22 08:31, Jack McGuinness via GitGitGadget wrote:
> > Jack McGuinness (3):
> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script
> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script p2
> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script p3

Junio already commented on the "area: t4202-log.sh" part of the
subject, so I won't repeat him.

About the "modernizing test script ..." part, it would be nice if the
different patches would be a bit more specific about what each one is
doing and "p2" or "p3" is redundant with the "2/3" or "3/3" added by
GitGitGadget. For example it could be replaced with "remove whitespace
after redirect" for the second patch.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux