On 4/18/2022 1:23 PM, Ævar Arnfjörð Bjarmason wrote: > This RFC series is a start at trying to combine the two differing RFC > versions of bundle URIs I [1] and Derrick Stolee [2] were kicking > around. > > = Layout > > This series arranged in the following way: > > * 01-08: "Prep" patches from both [1] and [2] which in principle could > graduate first to "master". > > I.e. they're prep fixes added for the two bundle-uri > implementations, but which either justify themselves, or e.g. expose > a now-static function via an API. > > I tried to move things into the "justify themselves" category > whenever possible, but may have overdone it e.g. for 02/36 > (originally an idea/commit of Derrick's, but I changed the > authorship as pretty much all of it at this point is something I > changed). > > For the "prep" changes that are only needed for later changes in the > series perhaps we should just squash them if they're small enough. I focused today on reading these first 8 patches with the intention that they can be submitted for full review and merging on their own. I think they don't fully succeed in justifying themselves (since not all public methods have callers) but it would be best to have these refactors settled before getting into the nitty gritty of the bundle URI feature. I mostly had a few nits here and there. I noticed that you did not always add your sign-off after mine, so please correct that when you send the next version (assuming you are planning to do so). I'll now start digging into the bigger parts of the series, but I expect it to take a lot longer to look at everything. Thanks, -Stolee
