On Mon, Apr 11, 2022 at 4:37 PM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > > Hi Plato Hey Phillip, Thanks for reviewing my patches, your input is welcomed! :) I'll reply your reviews and Ævar's in the following days. I need some time to read dir-iterator again in combination with your comments. > > I think this would be a useful addition to git, thanks for working on > it. I've left some comments on the individual patches. In general I > think this series would benefit from trying to work with the existing > code and change one aspect at a time in stages rather than rewriting > large chunks all at once. Agreed, I'll change one aspect at a time. First, I'll include suggested changes from this version and also convert entry.c to use dir-iterator instead of opendir, readdir, closedir API and submit v2. Then I'll spend some time understanding read_directory_recursive() and search for possible parts that can be cleaned up using dir-iterator. I'll compile a set of possible customer candidates for dir-iterator as reference. This will take some time since I'll prepare for the upcoming GSoC as a possible contributor. Thanks, Plato > > Best Wishes > > Phillip > > On 10/04/2022 12:18, Plato Kiorpelidis wrote: > [...]
