Re: [PATCH v3 25/29] CI: set CC in MAKEFLAGS directly, don't add it to the environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 15, 2022 at 6:52 AM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
>
> But unless I'm missing something that's already been the case on
> "master" for a while, i.e. this is the master run showing that we'll
> invoke "gcc":
> https://github.com/git/git/runs/6031562726?check_suite_focus=true#step:3:6

That would be unfortunate, considering the code in next (and all other
not yet affected) branches still has the definition added in
176441bfb58 (ci: build Git with GCC 9 in the 'osx-gcc' build job,
2019-11-27) and which survived your travis-ci removal series.

Note that the value of CC is only relevant when the code is built, and
GitHub actions provides its own for all tasks and at least this "mock"
run (which adds `$CC --version` before make) with next seems to
indicate the right compiler is still being used there and hopefully
also in all other unaffected runs from all stable branches:

  https://github.com/carenas/git/runs/6041742809

Eitherway, making sure that we really use gcc in the jobs that are
tagged as such will make these extra runs (and their additional CPU
time) less wasteful and should be corrected ASAP.

Carlo




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux