On Wed, Apr 13, 2022 at 5:13 PM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
> Remove code that I missed in 4a6e4b96026 (CI: remove Travis CI
> support, 2021-11-23). This code was only called from or used by the
> now-removed .travis.yml, or needed by the Travis CI environment.
>
> For the symlinking in ci/run-build-and-tests.sh: Back when
> 3c93b829205 (travis-ci: build Git during the 'script' phase,
> 2018-01-08) and 4b060a4d973 (ci: use a junction on Windows instead of
> a symlink, 2019-01-27) adjusted this "ln" command, the Windows build
> would use ci/run-build-and-tests.sh.
>
> As seen in 889cacb6897 (ci: configure GitHub Actions for CI/PR,
> 2020-04-11) the current windows build uses a different entry point
> under the GitHub CI, which doesn't use this .prove caching. Namely
> "ci/run-test-slice.sh".
>
> We can be certain that it's never used in "ci/run-test-slice.sh"
> because to have a ".prove" file we'd need to use "--state=save", which
> we only do in the dead Azure codepath in ci/lib.sh. If it were used it
> would do the wrong thing, because the different test slices would each
> try to clobber the same "t/.prove" file.
>
> If a subsequent run then used the -"-state=failed,slow,save" it would
s/-"-/--"/
> defeat the purpose of "ci/run-test-slice.sh", since all slices would
> then run all tests. I.e. behavior of prove's "--state" options is to
> select tests to run from the provided "--state" file, in addition to
> those specified on the command-line.
>
> For ci/run-docker{,-build}.sh: It was likewise last referenced in the
> .travis.yml removed in my 4a6e4b96026. The current "dockerized" run in
> ".github/workflows/main.yml" calls the same entry points as the main
> "regular" job.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
