"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > On 2022-04-12 at 20:14:34, Jonathan Tan wrote: > > This seems like you're using the commit message as the reflog message - > > is this necessary? For what it's worth, all tests still pass if I > > replace "msg" with "NULL". > > I think that's what the existing stash code does, and so I did the same > here. It's not strictly necessary, but it's a nice to have. > > I didn't think it worth testing, because I don't think we test it > elsewhere, either. > > > It might be worth adding tests that check that the exported stashes are > > in the expected format (to ensure that we can read stashes exported from > > another Git version) but I don't think that has to block the submission > > of this patch set. > > There's a tiny patch for that for the base commit, but you're right that > some more tests wouldn't hurt. I can send a followup patch or two as > part of a new series. OK, these sound good to me.
