Derrick Stolee <derrickstolee@xxxxxxxxxx> writes: > >> Signed-off-by: COGONI Guillaume <cogoni.guillaume@xxxxxxxxx> >> Co-authored-by: BRESSAT Jonathan <git.jonathan.bressat@xxxxxxxxx> >> Helped-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxx> >> Helped-by: Derrick Stolee <derrickstolee@xxxxxxxxxx> > > Here, you probably want to flip the order here (Helped-by, then > Co-authored-by, then Signed-off-by). You probably also want the > sign-off of your co-author, too. > > The sign-off should be the last thing in the message, because > the previous lines are covered by that sign-off. Yup. It would record the order of events that lead to this exact patch, which is what we want to capture. With help by these people, together with the co-author(s), the patch was written and author(s) signed-off before it was sent out to the list. > ... > And this is the necessary fix. > > Thanks for working on this! Indeed. And thanks for a helpful review.
