On Mon, Apr 04, 2022 at 05:26:10PM -0700, Carlo Marcelo Arenas Belón wrote: > On Mon, Apr 04, 2022 at 06:40:35PM -0400, rsbecker@xxxxxxxxxxxxx wrote: > > On April 4, 2022 6:33 PM, Junio C Hamano wrote: > > >To: Randall S. Becker <rsbecker@xxxxxxxxxxxxx> > > >Cc: Git Mailing List <git@xxxxxxxxxxxxxxx>; git-packagers@xxxxxxxxxxxxxxxx > > >Subject: Re: [ANNOUNCE] Git v2.36.0-rc0 - Build failure on NonStops > > > > > >CSPRNG_METHOD? > > > > We already have > > > > CSPRNG_METHOD = openssl > > > > In the config for NonStop. Should that not have worked? > > only if you are not telling your openssl to hide that function[1] > > Carlo > > [1] https://www.openssl.org/docs/manmaster/man3/RAND_bytes.html neverming, it seems we forgot to track this header somehow, so will need something like (untested and likely to need changes to support NO_OPENSSL) Carlo --- >8 --- diff --git a/git-compat-util.h b/git-compat-util.h index 4d444dca274..68a9b9cd975 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -525,6 +525,10 @@ void warning_errno(const char *err, ...) __attribute__((format (printf, 1, 2))); #include <openssl/x509v3.h> #endif /* NO_OPENSSL */ +#ifdef HAVE_OPENSSL_CSPRNG +#include <openssl/rand.h> +#endif + /* * Let callers be aware of the constant return value; this can help * gcc with -Wuninitialized analysis. We restrict this trick to gcc, though,
