Edmundo Carmona Antoranz <eantoranz@xxxxxxxxx> writes: > On Mon, Apr 4, 2022 at 8:21 PM Edmundo Carmona Antoranz > <eantoranz@xxxxxxxxx> wrote: >> >> When using ranges, use their sizes as the limit for progress >> instead of the size of the full file. >> >> ' >> >> +test_expect_success 'blame progress on a full file' ' >> + cat >progress.txt <<-\EOF && >> + a simple test file >> + >> + no relevant content is expected here >> + >> + If the file is too short, we cannot test ranges >> + >> + EOF >> + git add progress.txt && >> + git commit -m "add a file for testing progress" && > > I wonder if the preceding section should be kept in a > separate 'setup test'? I actually wonder why we need a *new* test file to run this test, instead of reusing what we already use in the existing test. > >> + GIT_PROGRESS_DELAY=0 \ >> + git blame --progress progress.txt > /dev/null 2> full_progress.txt && Style: git blame --progress progress.txt >/dev/null 2>full_progress.txt &&
