From: Labnan <khalidmasum@xxxxxxxxxxxxx> T3501 contains two test cases where we used to check if a file exists using test -f which is not necessary because we already have grep after it. Also the use of git rev-parse can be hidden using test_cmp_rev. This patch tries to resolve these two issues in T3501. Sorry for the extra email that was not sent to the right place. I am still struggling to work with the mailing list. Labnann (1): t3501: remove redundant file check and stop ignoring git <cmd> exit code t/t3501-revert-cherry-pick.sh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) Range-diff against v2: 1: 8b7d38a66f < -: ---------- t3501: use test_path_is_* functions 2: 04b0bf1c5d < -: ---------- t3501: don't ignore "git <cmd>" exit code 3: 36445b40fb < -: ---------- t3501: test cherry-pick revert with oids -: ---------- > 1: aeb28e3249 t3501: remove redundant file check and stop ignoring git <cmd> exit code -- 2.35.1.windows.2