On Fri, Apr 1, 2022 at 6:21 AM Victoria Dye <vdye@xxxxxxxxxx> wrote: > Thanks for working out some ways to make 'mv' behave more nicely with sparse > checkouts! I did my best to address some of the specific implementation > questions you had in your commit messages. Beyond that, my main points of > feedback (beyond some formatting nits and implementation questions) are: > > * Patch 2 deals with sparse directories, which won't show up until you > enable sparse index; since you can't test that yet, you should save the > patch for your "sparse index integration" series. > * Patch 4 should either be moved to the beginning of the series (with the > tests flagged with 'test_expect_failure' until the patch that fixes the > associated behavior), or split up with the tests associated with a change > moved into the patch that makes that change. > > And, as always, I'm happy to answer any questions and/or clarify weird > behavior you encounter while making changes to this (or subsequent) series! Hi Victoria, Thanks a lot for the detailed and informative feedback, they are incredibly helpful to guide me through this first attempt! I have read them all and am preparing corresponding fixes :-) -- Thanks & Regards, Shaoxuan
