On Wed, Mar 30 2022, Junio C Hamano wrote: > "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > >> brian m. carlson (4): >> object-name: make get_oid quietly return an error >> builtin/stash: factor out revision parsing into a function >> builtin/stash: provide a way to export stashes to a ref >> builtin/stash: provide a way to import stashes from a ref >> >> Documentation/git-stash.txt | 29 +++- >> builtin/stash.c | 324 ++++++++++++++++++++++++++++++++++-- >> cache.h | 1 + >> object-name.c | 6 +- >> t/t3903-stash.sh | 52 ++++++ >> 5 files changed, 397 insertions(+), 15 deletions(-) > > Merged to 'seen', t3903 seems to have a handful of breakages. > e.g. https://github.com/git/git/runs/5763421702?check_suite_focus=true One is a segfault because of a missing STRBUF_INIT: diff --git a/builtin/stash.c b/builtin/stash.c index 7cab57bbe4b..92a1682941c 100644 --- a/builtin/stash.c +++ b/builtin/stash.c @@ -1931,7 +1931,7 @@ static int do_export_stash(const char *ref, size_t argc, const char **argv) struct object_id *items = NULL; int nitems = 0, nalloc = 0; int res = 0; - struct strbuf revision; + struct strbuf revision = STRBUF_INIT; const char *author, *committer; /*
