From: Labnann <khalid.masum.92@xxxxxxxxx>
Two test -f are present in t3501. They can be replaced with appropriate
helper function: test_path_is_file
Signed-off-by: Labnann <khalid.masum.92@xxxxxxxxx>
---
[GSoC][PATCH] t3501: Use test_path_is_* Functions
Two test -f are present in t3501. They can be replaced with appropriate
helper function: test_path_is_file. Which makes the script more readable
and gives better error messages.
Signed-off-by: Labnann khalid.masum.92@xxxxxxxxx
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1195%2FLabnann%2Ft3501-helper-functions-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1195/Labnann/t3501-helper-functions-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1195
t/t3501-revert-cherry-pick.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3501-revert-cherry-pick.sh b/t/t3501-revert-cherry-pick.sh
index 8617efaaf1e..45492a7ed09 100755
--- a/t/t3501-revert-cherry-pick.sh
+++ b/t/t3501-revert-cherry-pick.sh
@@ -67,7 +67,7 @@ test_expect_success 'cherry-pick after renaming branch' '
git checkout rename2 &&
git cherry-pick added &&
test $(git rev-parse HEAD^) = $(git rev-parse rename2) &&
- test -f opos &&
+ test_path_is_file opos &&
grep "Add extra line at the end" opos &&
git reflog -1 | grep cherry-pick
@@ -78,7 +78,7 @@ test_expect_success 'revert after renaming branch' '
git checkout rename1 &&
git revert added &&
test $(git rev-parse HEAD^) = $(git rev-parse rename1) &&
- test -f spoo &&
+ test_path_is_file spoo &&
! grep "Add extra line at the end" spoo &&
git reflog -1 | grep revert
base-commit: 805e0a68082a217f0112db9ee86a022227a9c81b
--
gitgitgadget
