Re: [PATCH v8 5/5] mergetools: add tools description to `git help config`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This commit is authored by you but is missing your sign off.
> Also, I did not give my sign-off on this patch (that can't be assumed,
> it always has to be expressively given).

I see, sorry. As this patch is a verbatim copy of the one you provided in the
last message I thought it was not appropriate to put my name on it (as it does
not contain any line created by me)... but now I know that in these cases the
right thing to do is to squash into the commit being commented on and add a
"Helped-by:" note. Right?

I'll fix this in v9.

Just to double check, please confirm this is what you want me to do:

  1. Squash 5/5 into  3/5

  2. Update the commit message to:

     2.1 Explain that the description is also added to the output of `git help
         config`

     2.2 Remove your name from "Signed-off-by:"

     2.3 Keep you name in "Helped-by:"

Thanks!


PS: I must confess this whole process of sending patches to the git mailing
list brings me back memories from "Asterix: The 12 Tasks" [1] :) :) :)

[1] https://www.youtube.com/watch?v=ZHRGjfEQpy4



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux