On Wed, Mar 30 2022, Tao Klerks wrote:
> On Wed, Mar 30, 2022 at 4:23 PM Tao Klerks <tao@xxxxxxxxxx> wrote:
>>
>> On Wed, Mar 30, 2022 at 3:27 PM Ævar Arnfjörð Bjarmason
>> <avarab@xxxxxxxxx> wrote:
>> >
>> >
>> > On Wed, Mar 30 2022, Tao Klerks via GitGitGadget wrote:
>> >
>> > > + if (tracking.matches > 1) {
>> > > + int status = die_message(_("not tracking: ambiguous information for ref %s"),
>> > > + orig_ref);
>> >
>> > This isn't per-se new, but I wonder if while we're at it we shold just
>> > quote '%s' here, which we'd usually do. I.e. this message isn't new, but
>> > referring again to "ref %s" (and not "ref '%s'") below is.
>> >
>>
>> I will fix the below, but I would default to not changing the above
>> unless someone thinks we should (not sure what the expectations are
>> around changing error messages unnecessarily)
>
> I take this back. I will update both - the change is in a "variable"
> part of the message anyway, and it's hard to imagine any tool
> actively/purposefully parsing the ref out of the message and being
> caught out by the new quotes. Any coordinating tool would already know
> what ref was being branched / having its tracking remote info updated.
Thanks, I'd be fine either way, it was just a suggestion.
Aside from what we do here we don't support third-party tooling that's
grepping our specific human-readable output, so changing any such
messaging is OK.
