On 9/29/07, Pierre Habouzit <madcoder@xxxxxxxxxx> wrote: > > > > > Signed-off-by: Pierre Habouzit <madcoder@xxxxxxxxxx> > > > > > - if (strcmp(argv[i], "-z")) > > > - revs->diff = 1; > > > + revs->diff = strcmp(argv[i], "-z") > > > + && strcmp(argv[i], "--color") > > > + && strcmp(argv[i], "--no-color"); > > > i += opts - 1; > > > continue; > > > > This can clear a previously set value of revs->diff. > > Good catch, that should be |= of course. > Perhaps also with an 'if' before to avoid clearing an already set revs->diff if the passed option does not match any of the three. Marco - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
