An altered version of https://lore.kernel.org/git/cover-v2-0.5-00000000000-20211119T202455Z-avarab@xxxxxxxxx sent a while ago, I ejected the json-writer.[ch] change, which had objections (on the v1, but it seems E-Mails were crossed). A the range-diff shows there's a couple of new trivial patches at the start. I then added a patch to the end to remove some i18n-markings that aren't used anywhere in-tree, let's not waste time translating things for hypothetical out-of-tree users as we migrate the last bits of functionality away from shellscripts. Ævar Arnfjörð Bjarmason (7): run-command.h: remove always unused "clean_on_exit_handler_cbdata" configure.ac: remove USE_PIC comment xdiff/xmacros.h: remove unused XDL_PTRFREE pack-bitmap-write: remove unused bitmap_reset() function object-store.h: remove unused has_sha1_file*() alloc.[ch]: remove alloc_report() function git-sh-setup: don't mark trees not used in-tree for i18n alloc.c | 21 ------------------- alloc.h | 1 - configure.ac | 3 --- .../coccinelle/the_repository.pending.cocci | 15 ------------- ewah/bitmap.c | 5 ----- ewah/ewok.h | 1 - git-sh-setup.sh | 20 +++++++++++------- object-store.h | 4 ---- run-command.h | 1 - xdiff/xmacros.h | 1 - 10 files changed, 13 insertions(+), 59 deletions(-) Range-diff against v2: -: ----------- > 1: bac78566135 run-command.h: remove always unused "clean_on_exit_handler_cbdata" -: ----------- > 2: 93dc689e1aa configure.ac: remove USE_PIC comment 1: 1e7e6d8d482 = 3: 05adde5b9e4 xdiff/xmacros.h: remove unused XDL_PTRFREE 2: c9026af8953 = 4: 6bd89f3cf42 pack-bitmap-write: remove unused bitmap_reset() function 3: 6d0ca249001 = 5: cf7969f8f67 object-store.h: remove unused has_sha1_file*() 4: 672bdffde83 ! 6: b60a4c24a28 alloc.[ch]: remove alloc_report() function @@ Commit message appears to have been used for demonstration purposes in that commit message. + These might be handy to manually use in a debugger, but keeping them + and the "count" member of "alloc_state" just for that doesn't seem + worth it. + Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> ## alloc.c ## +@@ alloc.c: union any_object { + }; + + struct alloc_state { +- int count; /* total number of nodes allocated */ + int nr; /* number of nodes left in current allocation */ + void *p; /* first free node in current allocation */ + +@@ alloc.c: static inline void *alloc_node(struct alloc_state *s, size_t node_size) + s->slabs[s->slab_nr++] = s->p; + } + s->nr--; +- s->count++; + ret = s->p; + s->p = (char *)s->p + node_size; + memset(ret, 0, node_size); @@ alloc.c: void *alloc_commit_node(struct repository *r) init_commit_node(c); return c; 5: 818f1a46d66 < -: ----------- json-writer.[ch]: remove unused formatting functions -: ----------- > 7: 7a82b1fd005 git-sh-setup: don't mark trees not used in-tree for i18n -- 2.35.1.1535.gf8d72b9da1e
