Re: [PATCH] worktree: include repair cmd in usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/25/22 2:05 PM, Des Preston via GitGitGadget wrote:
The worktree repair command was not added to the usage menu for the
worktree command. This commit adds the usage of 'worktree repair'
according to the existing docs.

Signed-off-by: Des Preston <despreston@xxxxxxxxx>

Thanks for fixing my oversight. This certainly should have been done by e8e1ff24c5 (worktree: add skeleton "repair" command, 2020-08-27).

One minor comment below...

diff --git a/builtin/worktree.c b/builtin/worktree.c
@@ -22,6 +22,7 @@ static const char * const worktree_usage[] = {
  	N_("git worktree move <worktree> <new-path>"),
  	N_("git worktree prune [<options>]"),
  	N_("git worktree remove [<options>] <worktree>"),
+	N_("git worktree repair [<path>]"),
  	N_("git worktree unlock <path>"),

The usage message should reflect the fact that `git worktree repair` can accept multiple paths, thus:

    N_("git worktree repair [<path>...]"),

which would also make it consistent with the synopsis in Documentation/worktree.txt.

With that change applied, consider this:

    Acked-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux