On 3/24/22 2:59 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
I hadn't signed off on this one yet ;-)
Sorry, I started a recent rebase based upon your version
of the commits and it had your signoff in it.
+is_value () {
+ test -n "$1" && test "${1::1}" != "-"
+}
${var:ofs:len} is a bash-ism. If you run this test under /bin/dash
instead of /bin/dash, you'll likely see it fail.
[...]
I'll simplify the function as you suggested and send a V9 in
the morning after GGG's CI finishes.
Thanks
Jeff
