On 3/23/2022 5:08 PM, Jonathan Tan wrote: > test_expect_success 'fetch --update-shallow' ' > + git init a-submodule && > + test_commit -C a-submodule foo && You add a submodule here so you can trigger the bug in this test, but... > test_expect_success 'fetch --update-shallow into a repo with submodules' ' > - git init a-submodule && > - test_commit -C a-submodule foo && This test was already named to be specific to submodules. The test names could probably use an update to describe what's really the difference between the two tests. Is there a reason we couldn't trigger the failure only in this second test, allowing us to still test --update-shallow when submodules are NOT present? Thanks, -Stolee
