Derrick Stolee <derrickstolee@xxxxxxxxxx> writes: > The thing I'm hoping to see from a final version is that a top-level > helper like test_expect_todo will expect at least one test_todo > helper to be executed inside of the test (perhaps communicated by > setting a special GIT_TEST_* environment variable?) and if any of I was hoping that we can do without test_expect_todo. test_expect_success can turn itself into test_expect_todo when it sees test_todo is invoked even once in it. And Phillip's outline actually implements the idea, if I am not mistaken. > the test_todo lines change from fail to pass, then that is > communicated as a _failure_ from CI's perspective. Let us discover > if we have accidentally "fixed" any of these test cases and update > the tests accordingly. In other words, we do not want to lose the "TODO fixed" we have been getting out of test_expect_failure, which I agree with. I am not sure if Phillip's outline had that feature. > I can predict writing a test case with multiple test_todo lines > that need to be updated to drop the test_todo helpers one-by-one > as a change is being introduced. Yes.
