On 3/21/22 7:18 PM, rsbecker@xxxxxxxxxxxxx wrote:
On March 21, 2022 6:06 PM, Jeff Hostetler wrote:
On 3/13/22 6:42 AM, Torsten Bögershausen wrote:
Hej Jeff,
[...]
It looks like the ...Cloned bit was added to the SDK in 10.13 [1].
All the other bits were defined sometime between 10.5 and 10.10.
I'll add something in V7 to guard that bit. I think 10.10 is old enough that we don't
need to special case those bits too.
I realize it is a bit late in the game, but would you consider a pre-hook and post-hook that automatically run with fsmonitor kicks off/terminates. I am thinking about use cases where this is integrated into more complex processes and it would be nice to have notifications of what fsmonitor is doing and when.
Thanks,
Randall
I hadn't really considered having a pre/post hook for the daemon.
I'm not opposed to it; I just hadn't thought about it.
By this I assume you mean something inside the fsmonitor--daemon
process that invokes the hooks when it is starting/stopping.
As opposed to something in a client command (like status) before
it implicitly started a daemon process. The latter method would
not give you post-hook events because the daemon usually outlives
the client command.
Perhaps you could elaborate on what you would use these hooks for
or how they would be helpful. It would be easy to add pre/post
hooks in the main thread of the daemon. However, I worry about
the prehook slowing the startup of the daemon -- since the client
status command might be waiting for it to become ready. I also
have a "health" thread in part3 that would be a candidate for
pre/post and any other periodic hooks that might be useful.
But again, before I suggest a design for this, it would be good
to know what kind of things you would want to do with them.
Jeff
