The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx> --- t/helper/test-reach.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/helper/test-reach.c b/t/helper/test-reach.c index 2f65c7f6a5..b5c4cbf6cc 100644 --- a/t/helper/test-reach.c +++ b/t/helper/test-reach.c @@ -40,7 +40,7 @@ int cmd__reach(int ac, const char **av) setup_git_directory(); if (ac < 2) - exit(1); + exit(EXIT_FAILURE); A = B = NULL; X = Y = NULL; -- 2.35.1
