The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may
be passed to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.
Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.
Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx>
---
builtin/mailsplit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c
index 7baef30569..9127ac49e3 100644
--- a/builtin/mailsplit.c
+++ b/builtin/mailsplit.c
@@ -73,7 +73,7 @@ static int split_one(FILE *mbox, const char *name, int allow_bare)
if (is_bare && !allow_bare) {
fprintf(stderr, "corrupt mailbox\n");
- exit(1);
+ exit(EXIT_FAILURE);
}
fd = xopen(name, O_WRONLY | O_CREAT | O_EXCL, 0666);
output = xfdopen(fd, "w");
--
2.35.1
