The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may
be passed to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.
Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.
Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx>
---
builtin/tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index e5a8f85693..55a808873c 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -315,7 +315,7 @@ static void create_tag(const struct object_id *object, const char *object_ref,
if (launch_editor(path, buf, NULL)) {
fprintf(stderr,
_("Please supply the message using either -m or -F option.\n"));
- exit(1);
+ exit(EXIT_FAILURE);
}
}
--
2.35.1
