The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may
be passed to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.
Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.
Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx>
---
builtin/help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/help.c b/builtin/help.c
index 222f994f86..e5ca9d4a6e 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -554,7 +554,7 @@ static const char *check_git_cmd(const char* cmd)
if (!exclude_guides || alias[0] == '!') {
printf_ln(_("'%s' is aliased to '%s'"), cmd, alias);
free(alias);
- exit(0);
+ exit(EXIT_SUCCESS);
}
/*
* Otherwise, we pretend that the command was "git
--
2.35.1
