On March 15, 2022 1:43 PM, Junio C Hamano wrote:
>Phillip Wood <phillip.wood123@xxxxxxxxx> writes:
>
>> diff --git a/compat/terminal.c b/compat/terminal.c index
>> da2f788137..bfbde3c1af 100644
>> --- a/compat/terminal.c
>> +++ b/compat/terminal.c
>> @@ -23,21 +23,28 @@ static void restore_term_on_signal(int sig)
>> static int term_fd = -1;
>
>The variable can be -1 to signal "no valid file descriptor".
>
>> static struct termios old_term;
>>
>> +static void close_term_fd(void)
>> +{
>> + if (term_fd)
>> + close(term_fd);
>> + term_fd = -1;
>> +}
>> +
>
>And we use that negative value after closing it.
>
>The check before closing it is wrong. It should be
>
> if (0 <= term_fd)
Should this expression succeed if term_fd == stdin? I might be missing the point here.
--Randall
