On 3/14/2022 4:18 PM, Junio C Hamano wrote: > "Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> From: Elijah Newren <newren@xxxxxxxxx> >> >> Add an explicit --no-cone to several sparse-checkout invocations in >> preparation for changing the default to cone mode. > > "several"? > > After this step, wouldn't it be a bug if in t/ there still are > "sparse-checkout init" or "sparse-checkout set" invocations for a > given test repository for the first time that do not mention > "--cone" or "--no-cone"? > > I am mostly asking for the criteria for reviewers to decide if they > spotted a bug or if it is expected omission when they spot, say, > "sparse-checkout init" without either. There are some "git sparse-checkout init" runs without the --no-cone, but since they are followed by a "set --no-cone", the difference is not important. Perhaps, as a later cleanup, we could go in and delete those "init" calls. Thanks, -Stolee
