Hi Christian, Thanks for reviewing. >On Tue, Mar 15, 2022 at 2:20 PM Christian Couder <christian.couder@xxxxxxxxx> wrote: > Thanks for this patch! I am curious what tool you used to prepare and > send it.This is not a big deal but when there is only one patch I > think [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From: > JAYATI...' line is not nécessary if you are sending the patch using > the same email address as what's in the 'From: JAYATI...' line. I am using git format-patch and send-email but had previously made some unnecessary modifications in the editor which I have now done away with. > It's nice to say why it's better to use functions like > test_path_is_dir() rather than `test -d`. Also it looks like the last > line could be formatted to be around the same length as previous > lines, instead of being significantly longer. > The sentence should end with a full stop. > > > Signed-off-by: JAYATI SHRIVASTAVA <gaurijove@xxxxxxxxx> > > It's also not a big deal, but, unless it's really a personal > preference, you might not want to use only uppercase letters for your > name, as it's not usual here. I have modified the commit message as per your reviews. However, I am not sure why my patches are still not showing up on the mailing list despite passing the --to/--cc/--in-reply-to options correctly to git send-email. What do you think might be the reason?
