Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Sat, 12 Mar 2022 18:20:59 -0800
Cc: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>, Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx>, Git List <git@xxxxxxxxxxxxxxx>, Elia Pinto <gitter.spiros@xxxxxxxxx>
In-reply-to: <220312.86o82bfo7x.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sat, 12 Mar 2022 11:38:33 +0100")
References: <20220304133702.26706-1-gitter.spiros@gmail.com> <20220308113305.39395-1-carenas@gmail.com> <CAPig+cSNgQ7SEYk9M=L7z0G=hteTdupKS6sHJL8T7zEp=zkLEA@mail.gmail.com> <CAPig+cT3TNFBMesYvYoncawfBdLqKL971SoP_J7F9FgnL10Eqw@mail.gmail.com> <CAPig+cSUTaPRvALJyJ8AxNB4wMFLyaWBOa8f+_8K6quPbxTT5A@mail.gmail.com> <xmqqv8wnm30q.fsf@gitster.g> <220309.86pmmulw77.gmgdl@evledraar.gmail.com> <CAPig+cQNeTAvWHm2GUGc2i=FKF2V6Gqkmmsw4kDOTzrSYEbgxA@mail.gmail.com> <220312.86o82bfo7x.gmgdl@evledraar.gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:

> But probably better is to just amend that to call it as "test-tool libc
> is-glibc-2.34-or-newer" or whatever. Then just do:
>
> 	if (__GLIBC__ > 2 || (__GLIBC__ == 2 && 34 >= __GLIBC_MINOR__))
> 		return 0;
> 	return 1;

Yuck.  Then we'd have yet another libc-is-glibc-2.36-or-newer
option, too, in the future?

Follow-Ups:
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Carlo Arenas

References:
- [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34
  - From: Elia Pinto
- [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Carlo Marcelo Arenas Belón
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Eric Sunshine
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Eric Sunshine
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Eric Sunshine
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Junio C Hamano
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Ævar Arnfjörð Bjarmason
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Eric Sunshine
- Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
  - From: Ævar Arnfjörð Bjarmason

Prev by Date: RE: Dealing with corporate email recycling
Next by Date: Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
Previous by thread: Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
Next by thread: Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]