Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > On Thu, 27 Sep 2007, Kristian Høgsberg wrote: > >> builtin-add.c | 8 ++++---- >> commit.h | 2 ++ > > Maybe move it to read-cache.c, just after "add_file_to_index()"? And > expose it via cache.h, not commit.h? Hmmmmmmmm. read-cache.c has been one of the lowest level files that define atomic operations, similar to sha1_file.c, and this function is much more porcelain-ish molecule operation. I'd rather not. What other useful molecules would we have and/or need to have by splitting existing standalone commands? rerere() is another, and probably we would need to rip the --with-tree bit from ls-files out to make it usable from builtin-commit. I do not think we would want to go to the "one file per function" extreme, either. Can we have a new file that hold these helper functions for porcelains? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
