On Fri, Mar 11, 2022 at 9:54 PM Jayati Shrivastava <gaurijove@xxxxxxxxx> wrote: > > For the microproject - "Use test_path_is_* functions in test scripts", is the intent > to do away with all calls to run_command* or to only remove those run_command* > calls where spawning a child process is an overkill (similar to https://github.com/git/git/commit/ffcb4e94d3) ? > If it's the latter then I am not sure how to identify such cases. > Would be great if you could clarify it further. Since `test_path_is_*` functions are more robust and debug-friendly. And are just wrappers around `test -(e|f|d|…)`. So, I think it's okay to use them wherever possible. But maybe someone on the mailing list will be able to provide better and correct explanation. cc(ing) Christian and mailing list. > Meanwhile, I'll try to work on another microproject to get familiar > with the patch submission process. We generally expect one microproject per student. But contributions are always welcome :) Thanks, Hariom