On 2022-03-10 at 21:38:42, Junio C Hamano wrote: > "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > > > I do want to preserve my nice --first-parent property. What I propose > > to do is this: I'll take your approach and reverse the parents to > > preserve the --first-parent chain and synthesize a predictable root > > commit based on the fake ID information we use for stashes when nobody's > > provided any. > > I am wondering if this can be made not an export format but a new > mechanism to store stashes that we use without having to export and > import. Capping the series of "stash entry" commits with an extra > commit that is continuously amended, and recording which stash entry > has already been used (and not to be shown) etc., in the log message > part of that commit, would give us "stash drop" without rewriting > all the history and would easily bring us to feature parity with the > reflog based implementation, I would hope? I had thought of providing a different stash format via extensions.stashFormat or something instead of this. The problem becomes backward compatibility: we essentially can't use stashes with older versions, and a very common use case in development is to work inside a Docker container or such where the version of Git is whatever the OS happened to ship, so such a change can be painful. It also impedes working with the repository using libgit2, which is heavily used in some environments (e.g., the Rust toolchain), until someone ports that change there. I'm not opposed to seeing such a format change where refs/stash itself becomes pushable via a format change, but for my present use case, I don't want to do that right now. It's possible that I might write such a series in the future, or someone else could write it, but I won't be writing it at the present moment. -- brian m. carlson (he/him or they/them) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
