Neeraj Singh <nksingh85@xxxxxxxxx> writes: >> I am wondering if fsync_or_die() interface is abstracted well >> enough, or we need things like "the fd is inside this directory; in >> addition to doing the fsync of the fd, please sync the parent >> directory as well" support before we start adding more components >> (if there is such a need, perhaps it comes before this step). >> > > I think syncing the parent directory is a separate fsyncMethod that > would require changes across the codebase to obtain an appropriate > directory fd. I'd prefer to treat that as a separable concern. Yeah, that would be a sensible direction to go. If we never did the "sync the parent" thing, we do not need it in the fsyncMethod world immediately. It can be added later. Thanks.
