On Wed, Mar 09 2022, Derrick Stolee wrote: > On 3/9/2022 8:16 AM, Ævar Arnfjörð Bjarmason wrote: >> Clear the "boundary_commits" object_array in release_revisions(). This >> makes a *lot* of tests pass under SANITIZE=leak, including most of the >> t/t[0-9]*git-svn*.sh tests. >> >> This includes the tests we had false-positive passes on before my >> 6798b08e848 (perl Git.pm: don't ignore signalled failure in >> _cmd_close(), 2022-02-01), now they pass for real. >> >> Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to >> list those that don't pass than to touch most of those 66. So let's >> introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests >> won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. > > This paragraph perhaps belongs a few patches earlier in "revisions > API: have release_revisions() release "cmdline"", or else there was > some swap of order here. Indeed, this was a bad case of a commit message being duplicated, will fix. Sorry!
