Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes: > +test_expect_success 'submodule update adds submodule.hasSuperproject to older repos' ' > + (cd super && > + test_unconfig submodule.hasSuperproject && So, before we run the test, we unconfig the variable in the SUPER repository, and then > + git submodule update && update the submodule, and then > + test_cmp_config -C submodule true --type=bool submodule.hasSuperproject go in to the submodule and check the value of the variable? Shouldn't the first part be more like (cd super && test_unconfig -C submodule submodule.hasSuperproject && if we want to make sure "submodule update" sets it there? > + ) > +'
