On Thu, Mar 10, 2022 at 12:52:31AM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Mar 09 2022, Taylor Blau wrote: > > > On Wed, Mar 09, 2022 at 10:10:33PM +0000, brian m. carlson wrote: > >> On 2022-03-08 at 13:38:06, Ævar Arnfjörð Bjarmason wrote: > >> > > >> > On Tue, Mar 08 2022, brian m. carlson wrote: > >> > > >> > I think the $subject of the patch needs updating. It's not removing all > >> > the assemply from the file, after this patch we still have the > >> > ARM-specific assembly. > >> > > >> > I don't have a box to test that on, but I wonder if that also triggers > >> > the pedantic mode? > >> > > >> > Perhaps: > >> > > >> > block-sha1: remove superfluous i386 and x86-64 assembly > >> > >> I suspect it has the same problem. My inclination is to just remove it, > >> because my guess is that the compiler has gotten smarter between 2009 > >> and now. > > > > Almost certainly. I don't have a machine to test it on, either, but I > > would be shocked if `make BLK_SHA=YesPlease DEVELOPER=1` worked on > > master today on an arm machine. > > Why is that? The -pedantic error is specifically about > "gnu-statement-expression", i.e. the bracket syntax, not the inline > assembly per-se. not sure how gcc version (as mentioned elsewhere) might affect this, but had built it successfully in aarch64 with gcc 4.8.4, and arm32v6 with gcc 10.3.1. Carlo
