Hi Tao, On Wed, 2 Mar 2022, Tao Klerks via GitGitGadget wrote: > diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh > index a0c123b0a77..ca90ee805e7 100755 > --- a/t/t7063-status-untracked-cache.sh > +++ b/t/t7063-status-untracked-cache.sh > @@ -90,6 +90,9 @@ test_expect_success 'setup' ' > cd worktree && > mkdir done dtwo dthree && > touch one two three done/one dtwo/two dthree/three && > + test-tool chmtime =-300 one two three done/one dtwo/two dthree/three && > + test-tool chmtime =-300 done dtwo dthree && > + test-tool chmtime =-300 . && At first I puzzled why we need `done`, `dtwo`, dthree` and `.`, too, but it makes sense: the invariant is that all of the files/directories whose mtime is adjusted in these three new lines have the same mtime. A similar issue is... > @@ -520,14 +519,14 @@ test_expect_success 'create/modify files, some of which are gitignored' ' > echo three >done/three && # three is gitignored > echo four >done/four && # four is gitignored at a higher level > echo five >done/five && # five is not gitignored > - echo test >base && #we need to ensure that the root dir is touched > - rm base && > + test-tool chmtime =-180 done/two done/three done/four done/five done && > + # we need to ensure that the root dir is touched (in the past); > + test-tool chmtime =-180 . && Here, where I needed a moment to understand the invariant (and hence the need to adjust more than just the root directory's mtime). > @@ -597,11 +595,11 @@ EOF > test_expect_success 'set up for test of subdir and sparse checkouts' ' > mkdir done/sub && > mkdir done/sub/sub && > - echo "sub" > done/sub/sub/file > + echo "sub" > done/sub/sub/file && > + test-tool chmtime =-120 done/sub/sub/file done/sub/sub done/sub done Similar situation here, too. All this is to say that this patch looks good to me. Thanks, Dscho
