On 3/8/2022 5:15 PM, Jeff Hostetler via GitGitGadget wrote: > Here is V2 of part 3 of my builtin FSMonitor series. > > I think I have addressed all of the feedback from V1. This includes: > Range-diff vs v1: > -: ----------- > 22: 524d449ed64 fsmonitor: never set CE_FSMONITOR_VALID on submodules > -: ----------- > 24: 95b9d4210d2 fsmonitor: on macOS also emit NFC spelling for NFD pathname > -: ----------- > 25: 5a0c1b7a287 t/lib-unicode-nfc-nfd: helper prereqs for testing unicode nfc/nfd > -: ----------- > 26: a45c1fd3000 t7527: test Unicode NFC/NFD handling on MacOS > -: ----------- > 27: e3e01677d93 fsmonitor-settings: NTFS and FAT32 on MacOS are incompatible I looked closely through the range-diff for the edits, then looked at these new patches closely. Outside of one thought about some debug output, I'm happy with this version. Thanks, -Stolee
