On Sat, Mar 05 2022, SZEDER Gábor wrote: > On Mon, Feb 21, 2022 at 03:46:35PM +0100, Ævar Arnfjörð Bjarmason wrote: >> As detailed in 2c8921db2b8 (travis-ci: build with the right compiler, >> 2019-01-17) the reason we started using $CC in $MAKEFLAGS as opposed >> to setting it in the environment was due to Travis CI clobbering $CC >> in the environment. > > This is not what 2c8921db2b8 detailed; in fact 2c8921db2b8 detailed > the exact opposite. Travis CI did not clobber $CC, it set $CC to what > we asked it to. We started using $CC in $MAKEFLAGS as opposed to > setting it in the environment, because our Makefile _ignores_ $CC in > the environment. Thanks. You're completely right, I don't know how I got that wrong when writing this summary. I'll fix it. But as for the body of the change I believe it looks good & is consistent with avoiding that issue. I.e. we'll set it in MAKEFLAGS both before and after this change. We just won't have a separate "CC" variable in the environment as far as GitHub's environment variable dump is concerned, which IMO makes this a lot easier to follow, i.e. we only need CC as a "make" argument, so let's add it and other such things to MAKEFLAGS only.
