[PATCH] log tests: fix "abort tests early" regression in ff37a60c369

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fix a regression in ff37a60c369 (log tests: check if grep_config() is
called by "log"-like cmds, 2022-02-16), a "test_done" command used
during development made it into a submitted patch causing tests 41-136
in t/t4202-log.sh to be skipped.

Reported-by: Fabian Stelzer <fs@xxxxxxxxxxxx>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
---

On Fri, Mar 04 2022, Fabian Stelzer wrote:

> After rebasing my work from <20220302090250.590450-1-fs@xxxxxxxxxxxx>
> on master I was a bit confused as to why my tests in t4202 were no
> longer executing and none of my changes did anything about it. I
> suppose this `test_done` is left over from testing and slipped into
> master?

Ouch! Yes, that's a rather obvious stupid mistake of mine that
shouldn't have escaped the lab. Sorry!

FWIW since we haven't run these tests in a while (not too long
though!) it's conceivable that CI would fail on them, but in addition
to passing locally here's passing CI for this change:
https://github.com/avar/git/runs/5420131756

So we should be OK with this change.

 t/t4202-log.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index 55fac644464..46e413bcc93 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-log.sh
@@ -484,7 +484,6 @@ do
 		)
 	'
 done
-test_done
 
 test_expect_success 'log --author' '
 	cat >expect <<-\EOF &&
-- 
2.35.1.1230.ga6e6579e98c




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux