This series fixes issues where we ignored the exit code of "git" due to it being on the LHS of a pipe, or because we interpolated its output with $() in a "test" construct, or had missing &&- chains in helper functions etc. This series is not made by string-replacing things in our test suite, if it was it would be much larger. These are all tests I've seen real hide real failures under SANITIZE=leak, either on current "master", or in combination with various local leak fixes I've got unsubmitted. In cases where I was starting to fix a pattern in a file I'd fix the rest of the file if it was easy, but otherwise these are all cases where I ran SANITIZE=leak, had a test pass, but having ASAN_OPTIONS log to a file revealed that we had memory leaks within that test. As an aside we still have various potential issues with hidden segfaults etc. in the test suite after this that are tricked to solve, because: * Our tests will (mostly) catch segfaults and abort(), but if we invoke a command that invokes another command it needs to ferry the exit code up to us. * run-command.c notably does not do that, so for e.g. "git push" tests where we expect a failure and an underlying "git" command fails we won't ferry up the segfault or abort exit code. * We have gitweb.perl and some other perl code ignoring return values from close(), i.e. ignoring exit codes from "git rev-parse" et al. * We have in-tree shellscripts like "git-merge-one-file.sh" invoking git commands, and if they fail returning "1", not ferrying up the segfault or abort() exit code. Ævar Arnfjörð Bjarmason (15): tests: change some 'test $(git) = "x"' to test_cmp tests: use "test_stdout_line_count", not "test $(git [...] | wc -l)" read-tree tests: check "diff-files" exit code on failure diff tests: don't ignore "git diff" exit code diff tests: don't ignore "git diff" exit code in "read" loop apply tests: use "test_must_fail" instead of ad-hoc pattern merge tests: use "test_must_fail" instead of ad-hoc pattern rev-parse tests: don't ignore "git reflog" exit code notes tests: don't ignore "git" exit code diff tests: don't ignore "git rev-list" exit code rev-list tests: don't hide abort() in "test_expect_failure" gettext tests: don't ignore "test-tool regex" exit code apply tests: don't ignore "git ls-files" exit code, drop sub-shell checkout tests: don't ignore "git <cmd>" exit code rev-list simplify tests: don't ignore "git" exit code t/t0002-gitfile.sh | 6 +- t/t1001-read-tree-m-2way.sh | 6 +- t/t1002-read-tree-m-u-2way.sh | 6 +- t/t1503-rev-parse-verify.sh | 5 +- t/t2012-checkout-last.sh | 51 ++++++--- t/t2200-add-update.sh | 33 ++++-- t/t3302-notes-index-expensive.sh | 6 +- t/t3303-notes-subtrees.sh | 9 +- t/t3305-notes-fanout.sh | 14 +-- t/t4020-diff-external.sh | 153 ++++++++++++------------- t/t4027-diff-submodule.sh | 7 +- t/t4123-apply-shrink.sh | 18 +-- t/t4128-apply-root.sh | 36 +++--- t/t6005-rev-list-count.sh | 43 ++++--- t/t6012-rev-list-simplify.sh | 12 +- t/t6102-rev-list-unexpected-objects.sh | 13 ++- t/t6407-merge-binary.sh | 22 +--- t/t7103-reset-bare.sh | 7 +- t/t7812-grep-icase-non-ascii.sh | 11 +- 19 files changed, 240 insertions(+), 218 deletions(-) -- 2.35.1.1226.g8b497615d32
